removed process start function when shuffled out #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
Jun 24, 2020
sasurobert
reviewed
Jun 24, 2020
| log.Debug("closing node") | ||
|
|
||
| switch endProcessArgument.Reason { | ||
| case core.ShuffledOut: |
There was a problem hiding this comment.
leave closing node final log
There was a problem hiding this comment.
done. also added description to the internal signal close log
sasurobert
approved these changes
Jun 24, 2020
iulianpascalau
approved these changes
Jun 25, 2020
| @@ -1346,7 +1345,7 @@ func startNode(ctx *cli.Context, log logger.Logger, version string) error { | |||
| case <-sigs: | |||
| log.Info("terminating at user's signal...") | |||
| case sig = <-chanStopNodeProcess: | |||
| log.Info("terminating at internal stop signal", "reason", sig.Reason) | |||
| log.Info("terminating at internal stop signal", "reason", sig.Reason, "description", sig.Description) | |||
LucianMincu
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed
handleAppCloseandnewStartInEpochfunctions from main as they were not working as expected. When running a node usingelrond-go-scripts-v2it caused additional log files due to multiple processes creation.