fixed more tests and made mocks follow new vmcommon interface #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
requested changes
Jun 25, 2020
| github.com/cpuguy83/go-md2man v1.0.10/go.mod h1:SmD6nW6nTyfqj6ABTjUi3V3JVMnlJmwcJI5acqYI6dE= | ||
| github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d h1:U+s90UTSYgptZMwQh2aRr3LuazLJIa+Pg3Kc1ylSYVY= |
| @@ -284,7 +284,8 @@ func TestAgarioContractJoinGameReward(t *testing.T) { | |||
| _, err = testContext.Accounts.Commit() | |||
…k/elrond-go into integrate-new-hooks
…k/elrond-go into integrate-new-hooks
sasurobert
previously approved these changes
Jun 25, 2020
sasurobert
previously approved these changes
Jun 25, 2020
andreibancioiu
previously approved these changes
Jun 25, 2020
iulianpascalau
previously approved these changes
Jun 25, 2020
| @@ -162,3 +162,11 @@ func ConvertToEvenHexBigInt(value *big.Int) string { | |||
|
|
|||
| return str | |||
| } | |||
|
|
|||
| // BooleanToInt takes a bool argument and returns 0 for false, 1 for true | |||
| func BooleanToInt(b bool) int { | |||
| require.Equal(t, scr.Value.Cmp(finalValue), 0) | ||
| } | ||
|
|
||
| func TestScProcessor_DoNotRefundGasToSenderForAsyncCall(t *testing.T) { |
sasurobert
approved these changes
Jun 25, 2020
iulianpascalau
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated new vmcommon + removed references to IELE for now.
Some tests are still failing but unrelated to to the new vmcommon.
New PR will follow integrating arwen promise implementation