Reject miniblocks which are not whitelisted #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SebastianMarian
commented
Jun 25, 2020
SebastianMarian
commented
- Implemented a mechanism which will add only whitelisted miniblocks received in pool
- Fixed an edge case in multidata interceptor related to a throttle mechanism
…received in pool * Fixed an edge case in multidata interceptor related to a throttle mechanism
iulianpascalau
previously approved these changes
Jun 25, 2020
| @@ -109,6 +109,7 @@ func (mdi *MultiDataInterceptor) ProcessReceivedMessage(message p2p.MessageP2P, | |||
| message.SeqNo(), | |||
| ) | |||
| if err != nil { | |||
| mdi.throttler.EndProcessing() | |||
SebastianMarian
dismissed stale reviews from iulianpascalau and sasurobert
via
c00ad0c
sasurobert
approved these changes
Jun 25, 2020
| @@ -1503,6 +1503,31 @@ func (tpn *TestProcessorNode) BroadcastBlock(body data.BodyHandler, header data. | |||
| _ = tpn.BroadcastMessenger.BroadcastTransactions(transactions) | |||
| } | |||
|
|
|||
| // WhiteListBody will whitelist all miniblocks from the given body for all the given nodes | |||
| func (tpn *TestProcessorNode) WhiteListBody(nodes []*TestProcessorNode, bodyHandler data.BodyHandler) { | |||
There was a problem hiding this comment.
could have whitelisted from header
iulianpascalau
approved these changes
Jun 25, 2020
LucianMincu
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.