En 6847 timestamp in p2p message #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jun 25, 2020
iulianpascalau
commented
- added timestamp on each and every p2p message.go
- added extra protection for all peers to follow the message protocol
- added extra protection for all peers to follow the message protocol
sasurobert
requested changes
Jun 26, 2020
cmd/seednode/config/config.toml
Outdated
| # 0 disables the feature. | ||
| [Marshalizer] | ||
| Type = "gogo protobuf" | ||
| SizeCheckDelta = 10 |
cmd/seednode/main.go
Outdated
| p2pConfigurationFile = "./config/p2p.toml" | ||
|
|
||
| // ErrMarshalizerCreation signals that the marshalizer cannot be created based on provided data | ||
| ErrMarshalizerCreation = errors.New("error creating marshalizer") |
There was a problem hiding this comment.
no need for this define - just create the error where it is needed. it is in main
p2p/data/proto/topicMessage.proto
Outdated
| import "github.com/gogo/protobuf/gogoproto/gogo.proto"; | ||
|
|
||
| message TopicMessage{ | ||
| bytes Payload = 1; |
| var ErrNilCacher = errors.New("nil cacher") | ||
| // ErrMessageUnmarshalError signals that an invalid message was received from a peer. There is no way to communicate | ||
| // with such a peer as it does not respect the protocol | ||
| var ErrMessageUnmarshalError = errors.New("message unmarshal error") |
There was a problem hiding this comment.
empty line to end of file
There was a problem hiding this comment.
there is an empty line there
p2p/libp2p/message.go
Outdated
| "github.com/ElrondNetwork/elrond-go/p2p/message" | ||
| "github.com/libp2p/go-libp2p-core/peer" | ||
| "github.com/libp2p/go-libp2p-pubsub" | ||
| ) | ||
|
|
||
| // NewMessage returns a new instance of a Message object | ||
| func NewMessage(msg *pubsub.Message) (*message.Message, error) { | ||
| func NewMessage(msg *pubsub.Message, marshalizer p2p.Marshalizer) (*message.Message, error) { | ||
| if marshalizer == nil { |
There was a problem hiding this comment.
chekc.ifnil with reflection
There was a problem hiding this comment.
better, check.IfNil()
p2p/libp2p/message.go
Outdated
| SeqNoField: msg.Seqno, | ||
| TopicsField: msg.TopicIDs, | ||
| SignatureField: msg.Signature, | ||
| KeyField: msg.Key, | ||
| } | ||
|
|
||
| var err error |
There was a problem hiding this comment.
no need for var err error
camilbancioiu
approved these changes
Jun 26, 2020
| Usage: "The `" + filePathPlaceholder + "` for the main configuration file. This TOML file contain the main " + | ||
| "configurations such as the marshalizer type", | ||
| Value: "./config/config.toml", | ||
| } |
There was a problem hiding this comment.
We didn't have an option for a custom configuration file before this?
sasurobert
approved these changes
Jun 27, 2020
LucianMincu
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.