Bug fix/sc cross built in call #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Jun 26, 2020
iulianpascalau
previously approved these changes
Jun 26, 2020
| Data: []byte(setUserNameTxData), | ||
| CallType: vmcommon.AsynchronousCall, | ||
| } | ||
| return &vmcommon.VMOutput{ReturnCode: vmcommon.Ok}, nil |
There was a problem hiding this comment.
return wmOutput, nil ?
…to bugFix/sc-cross-builtIn-call
sasurobert
dismissed stale reviews from iulianpascalau and andreibancioiu
via
69e4c8d
SebastianMarian
previously approved these changes
Jun 26, 2020
iulianpascalau
previously approved these changes
Jun 26, 2020
sasurobert
dismissed stale reviews from iulianpascalau and SebastianMarian
via
f42dba5
SebastianMarian
approved these changes
Jun 26, 2020
| @@ -16,7 +16,7 @@ func TestChangeOwnerAddress_ProcessBuiltinFunction(t *testing.T) { | |||
|
|
|||
| coa := changeOwnerAddress{} | |||
|
|
|||
| owner := []byte("sender") | |||
| owner := []byte("send") | |||
There was a problem hiding this comment.
the length is verified for the validity of the input, so length must be equal.
andreibancioiu
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built in function has to create cross shard SC result if destination is not in shard