Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject not whitelisted cross txs dest me #2031

Merged
merged 6 commits into from Jun 27, 2020
Merged

Reject not whitelisted cross txs dest me #2031

merged 6 commits into from Jun 27, 2020

Conversation

SebastianMarian
Copy link
Contributor

  • Implemented whitelist mechanism for cross shard transactions dest me

@SebastianMarian SebastianMarian added the type:feature New feature or request label Jun 26, 2020
@SebastianMarian SebastianMarian self-assigned this Jun 26, 2020
@sasurobert sasurobert self-requested a review June 26, 2020 21:25
@iulianpascalau iulianpascalau self-requested a review June 27, 2020 10:19
@andreibancioiu andreibancioiu self-requested a review June 27, 2020 10:32
LucianMincu
LucianMincu approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

andreibancioiu
andreibancioiu approved these changes Jun 27, 2020
View reviewed changes
process/interceptors/processor/miniblockInterceptorProcessor.go
if err != nil {
return err
}
hash := interceptedMiniblock.Hash()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

process/dataValidators/txValidator.go
return process.ErrWrongTypeAssertion
}

isTxCrossShardDestMe := interceptedTx.SenderShardId() != txv.shardCoordinator.SelfId() &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LucianMincu LucianMincu merged commit e5f38b2 into development Jun 27, 2020
@LucianMincu LucianMincu deleted the reject-not-whitelisted-cross-txs-dest-me branch June 27, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreibancioiu andreibancioiu andreibancioiu approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@sasurobert sasurobert Awaiting requested review from sasurobert

Assignees

@SebastianMarian SebastianMarian

Labels
type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SebastianMarian @andreibancioiu @LucianMincu @iulianpascalau