Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: fix: TrimPrefix instead of TrimLeft for trimming prefixes #2068

Merged
merged 1 commit into from
Jul 3, 2020
Merged

consensus: fix: TrimPrefix instead of TrimLeft for trimming prefixes #2068

merged 1 commit into from
Jul 3, 2020

Conversation

AdoAdoAdo
Copy link
Contributor

Fix: TrimLeft removes characters left not prefixes, use TrimPrefix instead.

@AdoAdoAdo AdoAdoAdo self-assigned this Jul 2, 2020
LucianMincu
LucianMincu approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 205216b into development Jul 3, 2020
@LucianMincu LucianMincu deleted the fix-trim-prefix branch July 3, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raduchis raduchis raduchis approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

Assignees

@AdoAdoAdo AdoAdoAdo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdoAdoAdo @raduchis @LucianMincu @iulianpascalau