Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Dockerfile arwen location #2070

Merged
merged 3 commits into from
Jul 3, 2020
Merged

fix Dockerfile arwen location #2070

merged 3 commits into from
Jul 3, 2020

Conversation

BenWhiteJam
Copy link
Contributor

@BenWhiteJam BenWhiteJam commented Jul 3, 2020 •
edited

  • removes hardcoded arwen version, instead fetches version from go.mod file
  • moves arwen wasm to lib folder in second build stage

LucianMincu
LucianMincu approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

iulianpascalau
iulianpascalau approved these changes Jul 3, 2020
View reviewed changes
docker/elrond/Dockerfile
@@ -7,12 +7,11 @@ RUN GO111MODULE=on go mod vendor
#Elrond node
WORKDIR /go/elrond-go/cmd/node
RUN go build -i -v -ldflags="-X main.appVersion=$(git describe --tags --long --dirty)"

RUN cp /go/pkg/mod/github.com/!elrond!network/arwen-wasm-vm@$(cat /go/elrond-go/go.mod | grep arwen-wasm-vm | sed 's/.* //')/wasmer/libwasmer_linux_amd64.so /lib/libwasmer_linux_amd64.so
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LucianMincu LucianMincu merged commit a14a5d2 into development Jul 3, 2020
@LucianMincu LucianMincu deleted the ben_prepare_dockerfiles branch July 3, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentin-lup valentin-lup valentin-lup approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@ccorcoveanu ccorcoveanu Awaiting requested review from ccorcoveanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenWhiteJam @valentin-lup @LucianMincu @iulianpascalau