renamed fullArchive to cleanOldEpochsData #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
Jul 9, 2020
AdoAdoAdo
reviewed
Jul 10, 2020
| @@ -40,7 +40,7 @@ func NewStorageServiceFactory( | |||
| if config == nil { | |||
| return nil, storage.ErrNilConfig | |||
| } | |||
| if config.StoragePruning.NumEpochsToKeep < minimumNumberOfEpochsToKeep && !config.StoragePruning.FullArchive { | |||
| if config.StoragePruning.NumEpochsToKeep < minimumNumberOfEpochsToKeep && !config.StoragePruning.CleanOldEpochsData { | |||
There was a problem hiding this comment.
why is cleanOldEpochsData relevant here?
There was a problem hiding this comment.
If the node doesn't remove old epochs, then there is no use for the NumEpochsToKeep so the check shouldn't be blocking. I can remove the condition if needed. Also, thanks for finding this because I have to change the boolean condition
There was a problem hiding this comment.
ok then you can keep the check, but remove negation
AdoAdoAdo
previously approved these changes
Jul 10, 2020
sasurobert
approved these changes
Jul 10, 2020
AdoAdoAdo
approved these changes
Jul 10, 2020
LucianMincu
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed boolean parameter
FullArchivetoCleanOldEpochsData