remove get from elastic indexer #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccorcoveanu
reviewed
Jul 10, 2020
core/indexer/common.go
Outdated
| @@ -198,7 +198,7 @@ func (cm *commonProcessor) convertScResultInDatabaseScr(sc *smartContractResult. | |||
| Code: string(sc.Code), | |||
| Data: decodedData, | |||
| PreTxHash: hex.EncodeToString(sc.PrevTxHash), | |||
| CallType: string(sc.CallType), | |||
| CallType: string(rune(sc.CallType)), | |||
There was a problem hiding this comment.
Why do we cast to rune?
There was a problem hiding this comment.
because for the moment call type is a strange character. also golang suggestion to use rune
There was a problem hiding this comment.
isn't callType integer (0, 1, 2)? if you save it as string (utf8) of course callType will be a strange character. You should save it like this I think :) strconv.Itoa(sc.CallType), this way you will get the correct value into the database (or better save it as integer in the json)
core/indexer/common.go
Outdated
| // update transaction | ||
| meta, serializedData = prepareTxUpdate(tx) | ||
| } else { | ||
| // write tx |
There was a problem hiding this comment.
Remove this extra comment
… into remove-get-from-elastic-indexer
bogdan-rosianu
previously approved these changes
Jul 10, 2020
… into remove-get-from-elastic-indexer
ccorcoveanu
approved these changes
Jul 10, 2020
bogdan-rosianu
approved these changes
Jul 10, 2020
LucianMincu
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all GET requests from elasticsearch observers to elasticsearch database.
Now all observers index data without checking if data for transaction and miniblocks are already in database.