check if node exists in genesis config before setting destination shard #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
reviewed
Jul 12, 2020
| @@ -264,7 +265,10 @@ func (e *epochStartBootstrap) prepareEpochZero() (Parameters, error) { | |||
| return Parameters{}, err | |||
| } | |||
|
|
|||
| shardIDToReturn := e.applyShardIDAsObserverIfNeeded(e.genesisShardCoordinator.SelfId()) | |||
| shardIDToReturn := e.genesisShardCoordinator.SelfId() | |||
| if !e.isNodeInGenesisNodesConfig() { | |||
There was a problem hiding this comment.
can you add a unit test for this :) ? good find.
There was a problem hiding this comment.
done. added 2 unit tests
iulianpascalau
approved these changes
Jul 12, 2020
sasurobert
approved these changes
Jul 12, 2020
LucianMincu
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the situation where if an entire testnet started with the same
prefs.tomlfile and it's value ofDestinationShardAsObserverwould have not been set todisabledthen all the nodes joined as observers in that shard.