Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing caller to SC upgrade guard #2177

Merged
merged 11 commits into from
Jul 28, 2020
Merged

Fix passing caller to SC upgrade guard #2177

merged 11 commits into from
Jul 28, 2020

Conversation

andreibancioiu
Copy link
Collaborator

@andreibancioiu andreibancioiu commented Jul 28, 2020 •
edited

  • A cross shard upgrade transaction would have resulted in a nil senderAccount - failure to get its address
  • Changed to use vmInput.CallerAddr

@andreibancioiu andreibancioiu self-assigned this Jul 28, 2020
sasurobert
sasurobert previously approved these changes Jul 28, 2020
View reviewed changes
process/smartContract/process.go Show resolved Hide resolved
raduchis
raduchis previously approved these changes Jul 28, 2020
View reviewed changes
@AdoAdoAdo
Merge pull request #2176 from ElrondNetwork/go-routine-indexing-valid…
46c9a81 
…ator-keys

fix validator keys indexing watchdog expiry - piggyback the PR
@AdoAdoAdo AdoAdoAdo dismissed stale reviews from raduchis and sasurobert via 46c9a81 July 28, 2020 16:11
sasurobert
sasurobert previously approved these changes Jul 28, 2020
View reviewed changes
@sasurobert
Merge pull request #2175 from ElrondNetwork/fix-blacklisted-peer-mess…
19f6f8f 
…ages

Reduced the large amount of p2p/antiflood prints
@raduchis raduchis self-requested a review July 28, 2020 17:13
@LucianMincu LucianMincu merged commit 6fd4b6f into development Jul 28, 2020
@LucianMincu LucianMincu deleted the fix-upgrade-caller branch July 28, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

@raduchis raduchis Awaiting requested review from raduchis

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@andreibancioiu @sasurobert @raduchis @SebastianMarian @LucianMincu @iulianpascalau @AdoAdoAdo @andrei-marinica