Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection for undeployed delegation #2187

Merged
merged 5 commits into from
Aug 7, 2020

Conversation

iulianpascalau
Copy link
Contributor

  • added protection against delegation to undeployed SC in the genesis process

@iulianpascalau iulianpascalau changed the title Protection undeployed delegation Protection for undeployed delegation Jul 30, 2020
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add for each manual testing scenario the following:

a) Prerequisites
b) Test steps
c) Expected results
d) Actual results

If there are parameters involved in testing what are the parameters boundaries and the expected results and actual results for testing inside boundaries, on boundaries and outside boundaries.

@iulianpascalau
Copy link
Contributor Author

iulianpascalau commented Aug 4, 2020

Can you please add for each manual testing scenario the following:

a) Prerequisites
b) Test steps
c) Expected results
d) Actual results

If there are parameters involved in testing what are the parameters boundaries and the expected results and actual results for testing inside boundaries, on boundaries and outside boundaries.

Testing procedure carried after the implementation:

  • generated nodesSetup.json and genesis.json files with a wrong SC address. The SC address used was a random one (not resulted from the owner address defined in genesisSmartContracts.json L3)
  • a small testing network was launched with the config files
  • without the fix, the network was able to boot up even though the delegation SC was deployed at an address not used by the .json files.
  • with this PR the aforementioned step was not possible to be carried because all nodes exit in error due to the fact that the delegation was done on an un-deployed SC.

Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit bab1fdf into development Aug 7, 2020
@LucianMincu LucianMincu deleted the protection-undeployed-delegation branch August 7, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants