Fix wrong genesis block save #2191
Conversation
Release 2020.07.26
Release 2020.07.27
Release 2020.07.28 1
Release 2020.07.29 1
Release 2020.07.29
| @@ -577,11 +577,6 @@ func prepareGenesisBlock(args *processComponentsFactoryArgs, genesisBlocks map[u | |||
| if errNotCritical != nil { | |||
| log.Error("error storing genesis shardblock", "error", errNotCritical.Error()) | |||
| } | |||
| hdrNonceHashDataUnit := dataRetriever.ShardHdrNonceHashDataUnit + dataRetriever.UnitType(genesisBlock.GetShardID()) | |||
There was a problem hiding this comment.
Actually this storage exists in each shard but only for self shard. In metachain it is created for every shard.
There was a problem hiding this comment.
But we do not need the shard genesis block stored inside the nonce-hash unit
There was a problem hiding this comment.
Ok, in this case you can move line 565 inside first if..else statement after line 570
There was a problem hiding this comment.
Can you please add for each manual testing scenario the following:
a) Prerequisites
b) Test steps
c) Expected results
d) Actual results
If there are parameters involved in testing what are the parameters boundaries and the expected results and actual results for testing inside boundaries, on boundaries and outside boundaries.
iulianpascalau
dismissed stale reviews from sasurobert and AdoAdoAdo
The base branch was changed.
Manual testing procedure:
shard header (nonce-hash)after a few epochs.