-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log inside pruning storer #2192
Conversation
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add for each manual testing scenario the following:
a) Prerequisites
b) Test steps
c) Expected results
d) Actual results
If there are parameters involved in testing what are the parameters boundaries and the expected results and actual results for testing inside boundaries, on boundaries and outside boundaries.
The base branch was changed.
fixed the condition when a log in printed and also changed the log level. The condition was not right as the counter is relevant only if a persister is re-opened and appended inside
active persisters
. Otherwise, the function doesn't affect the state of active persisters.Testing scenarios & Acceptance criteria:
Test reference (internal):
pruning-stuck-shard-log-1