Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log inside pruning storer #2192

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Conversation

bogdan-rosianu
Copy link
Contributor

@bogdan-rosianu bogdan-rosianu commented Jul 31, 2020

fixed the condition when a log in printed and also changed the log level. The condition was not right as the counter is relevant only if a persister is re-opened and appended inside active persisters. Otherwise, the function doesn't affect the state of active persisters.

Testing scenarios & Acceptance criteria:

  1. Log no longer displayed when not needed. For example, the transition from epoch 0 to epoch 1 should not trigger the log
  2. Log still displayed when a shard remains stuck. For example, if the entire network is in epoch 5 and a shard is still in epoch 2, at epoch change the other shards should keep more epochs in order to provide data to the shard with issues. => log displayed

Test reference (internal):
pruning-stuck-shard-log-1

@bogdan-rosianu bogdan-rosianu added the type:feature New feature or request label Jul 31, 2020
@bogdan-rosianu bogdan-rosianu self-assigned this Jul 31, 2020
SebastianMarian
SebastianMarian previously approved these changes Aug 1, 2020
iulianpascalau
iulianpascalau previously approved these changes Aug 3, 2020
@iulianpascalau iulianpascalau changed the base branch from fix-wrong-genesis-saving to master August 3, 2020 07:58
@iulianpascalau iulianpascalau dismissed stale reviews from SebastianMarian and themself August 3, 2020 07:58

The base branch was changed.

iulianpascalau
iulianpascalau previously approved these changes Aug 3, 2020
SebastianMarian
SebastianMarian previously approved these changes Aug 3, 2020
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add for each manual testing scenario the following:

a) Prerequisites
b) Test steps
c) Expected results
d) Actual results

If there are parameters involved in testing what are the parameters boundaries and the expected results and actual results for testing inside boundaries, on boundaries and outside boundaries.

@bogdan-rosianu bogdan-rosianu changed the base branch from master to development August 10, 2020 08:01
@bogdan-rosianu bogdan-rosianu dismissed stale reviews from SebastianMarian and iulianpascalau August 10, 2020 08:01

The base branch was changed.

@LucianMincu LucianMincu merged commit 5c3538c into development Aug 11, 2020
@LucianMincu LucianMincu deleted the fix-pruning-storer-log branch August 11, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants