Soft-fork boilerplate #2199
Soft-fork boilerplate #2199
Conversation
…me options from bool to uint32 representing the epoch number when will become active
core/forking/genericEpochNotifier.go
Outdated
| } | ||
|
|
||
| // NotifyAllPrepare does nothing | ||
| func (gen *genericEpochNotifier) NotifyAllPrepare(_ data.HeaderHandler, _ data.BodyHandler) { |
There was a problem hiding this comment.
I do not think Prepare is needed. only notifyAll - but let's have a talk about it.
There was a problem hiding this comment.
I had to implement the interface in order to get this component notified by the epochStartNotifier
There was a problem hiding this comment.
ok. we have to see the edge cases when changing epoch. I think we need it in NotifyAllPrepare - as the code is right now the activation of the new Header version, and the activation of certain features.
Do not forget to add the activation of a new header version when is needed ?
There was a problem hiding this comment.
new epoch block (start of epoch block from meta, then shard should have the new header version and to have the required features already activated at block creation and at block processing time.
There was a problem hiding this comment.
Can you please add for each manual testing scenario the following:
a) Prerequisites
b) Test steps
c) Expected results
d) Actual results
If there are parameters involved in testing what are the parameters boundaries and the expected results and actual results for testing inside boundaries, on boundaries and outside boundaries.
- added an integration test
…epoch notifier and taking care of the hardfork processing
# Conflicts: # genesis/errors.go
iulianpascalau
dismissed stale reviews from sasurobert and raduchis
via
9928d35
iulianpascalau
dismissed stale reviews from raduchis and sasurobert
via
c22293f
this PR should and will not cause breaking changes with the launched mainnet
Testing steps:
system tested using current version of erd-py for deploy SC and builtin functions