integrates the output flag for filegen #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWhiteJam
requested review from
valentin-lup,
LucianMincu,
iulianpascalau and
bogdan-rosianu
| @@ -98,7 +98,8 @@ jobs: | |||
| -num-of-observers-in-metachain 1 \ | |||
| -chain-id ${{ github.sha }} \ | |||
| -hysteresis $HYSTERESIS \ | |||
| -stake-type delegated | |||
| -stake-type delegated \ | |||
| -output-directory ./ | |||
There was a problem hiding this comment.
why not a new directory? like ./output
There was a problem hiding this comment.
as it creates the according files on the deployment server path which then get picked up by the config file sed and the kube config map creation step.
Would push the update to a separate folder into a more general deployment file update branch to parse files more dynamic and be less error prone for future config file creations.
iulianpascalau
approved these changes
Aug 5, 2020
valentin-lup
approved these changes
Aug 5, 2020
bogdan-rosianu
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrates the output directory flag for filegen config pre-processing