En 7295 get username route #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
requested changes
Aug 5, 2020
bogdan-rosianu
changed the base branch from
development
to
bugFix/relayed-invalid-nonce
sasurobert
previously approved these changes
Aug 5, 2020
sasurobert
approved these changes
Aug 10, 2020
iulianpascalau
approved these changes
Aug 10, 2020
| } | ||
|
|
||
| addr, err := n.addressPubkeyConverter.Decode(address) | ||
| account, err := n.getAccountHandler(address) |
There was a problem hiding this comment.
GJ! Same level of abstraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an API endpoint for getting the username for a given address.
Testing steps:
a) Prerequisites
-a testnet which has the following routes enabled in
api.toml:-
address/:address/username-
address/:addressb) Test steps
-make API requests to the routes
c) Expected results
-on the
address/:address/usernameroute only the username should be returned-the username should be visible also on the route
address/:address-if the given address exists and it has an username set, it should be returned.
-if the given address does not exist an error will be returned.
-if the given address exists, but it doesn't have an username set, an empty username will be returned.
d) Actual results
-tested on a local testnet and the acceptance criteria is met