Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests - transactions scenarios #2204

Merged
merged 8 commits into from
Aug 10, 2020
Merged

Integration tests - transactions scenarios #2204

merged 8 commits into from
Aug 10, 2020

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Aug 5, 2020 •
edited

Added new integration tests for transactions:

  • move balance scenarios
  • smart contract deploys and calls
  • builtin function calls

@miiu96 miiu96 requested a review from sasurobert August 5, 2020 13:05
@miiu96 miiu96 marked this pull request as ready for review August 6, 2020 13:00
sasurobert
sasurobert previously approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@sasurobert sasurobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look nice!

@iulianpascalau iulianpascalau self-requested a review August 7, 2020 15:52
iulianpascalau
iulianpascalau reviewed Aug 7, 2020
View reviewed changes
Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! 👍 Minor stuff related to test execution

integrationTests/multiShard/txScenarios/builtinFunctions_test.go Outdated
)

func TestTransaction_TransactionBuiltinFunctionsScenarios(t *testing.T) {
t.Parallel()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an issue running this in parallel. For integration tests, might remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

integrationTests/multiShard/txScenarios/moveBalance_test.go Outdated
)

func TestTransaction_TransactionMoveBalanceScenarios(t *testing.T) {
t.Parallel()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no t.Parallel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

integrationTests/multiShard/txScenarios/scCalls_test.go Outdated
)

func TestTransaction_TransactionSCScenarios(t *testing.T) {
t.Parallel()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.Parallel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

LucianMincu
LucianMincu approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed.

@LucianMincu LucianMincu merged commit f4c2dc5 into development Aug 10, 2020
@LucianMincu LucianMincu deleted the EN-7283-integration-tests-tx-scenarios branch August 10, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miiu96 @sasurobert @LucianMincu @iulianpascalau