-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exchanges integration - additions #2205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
Aug 5, 2020
camilbancioiu
previously approved these changes
Aug 5, 2020
andreibancioiu
dismissed stale reviews from camilbancioiu and sasurobert
via
August 6, 2020 11:33
e872d16
sasurobert
approved these changes
Aug 7, 2020
camilbancioiu
approved these changes
Aug 8, 2020
LucianMincu
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevBlockHash
in the response ofblock
endpoints - @miiu96erd_highest_notarized_block_by_metachain_for_current_shard
toerd_highest_final_nonce
erd_nonce_highest_final
when committing blocks at meta as wellnetwork/status
as wellHow to test:
node/status
on both shard and metachain nodes. Inspect the fielderd_highest_final_nonce
.network/status
on both node and proxy and inspect the newly added field.