Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchanges integration - additions #2205

Merged
merged 7 commits into from
Aug 10, 2020
Merged

Conversation

andreibancioiu
Copy link
Collaborator

@andreibancioiu andreibancioiu commented Aug 5, 2020

  • added prevBlockHash in the response of block endpoints - @miiu96
  • renamed erd_highest_notarized_block_by_metachain_for_current_shard to erd_highest_final_nonce
  • set the metric erd_nonce_highest_final when committing blocks at meta as well
  • include the metric in the response of network/status as well

How to test:

  • access node/status on both shard and metachain nodes. Inspect the field erd_highest_final_nonce.
  • access network/status on both node and proxy and inspect the newly added field.

@andreibancioiu andreibancioiu added the type:feature New feature or request label Aug 5, 2020
@sasurobert sasurobert self-requested a review August 5, 2020 15:29
sasurobert
sasurobert previously approved these changes Aug 5, 2020
camilbancioiu
camilbancioiu previously approved these changes Aug 5, 2020
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit cccd4a9 into development Aug 10, 2020
@LucianMincu LucianMincu deleted the exchanges-integration-dev branch August 10, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants