Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

En 7301 fix boostrap from storage #2208

Merged
merged 6 commits into from
Aug 7, 2020

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Aug 6, 2020

  • return the nodes config after starting from storage when calling Bootstrap()

Steps used in testing:

  • connect to an existing testnet using StartInEpochEnabled = true in config.toml in metachain shard. Let it synchronize.
  • gracefully close the node, wait a couple of minutes, change the setting StartInEpochEnabled = false in config.toml.
  • start the node, the node should be able to catch-up and sync properly the chain. Without the fix, the node was not able to sync because it would have a wrong view of the network (the eligible/waiting list was the one of the epoch 0) and almost all headers would have been discarded by the interceptors saying: invalid signature.

@iulianpascalau iulianpascalau self-assigned this Aug 6, 2020
@iulianpascalau iulianpascalau added the type:bug Something isn't working label Aug 6, 2020
@LucianMincu LucianMincu merged commit a922100 into development Aug 7, 2020
@LucianMincu LucianMincu deleted the EN-7301-fix-boostrap-from-storage branch August 7, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants