Termui updates #2212

miiu96 · 2020-08-07T11:37:29Z

Modified termui gui:

added a gouge with epoch info (shows how many rounds passed in current epoch and time remained from current epoch)
added a gouge with epoch traffic (show an estimation of how many bytes was send/received in current epoch)

bogdan-rosianu · 2020-08-10T14:21:49Z

core/converters_test.go

+		2*secondsInAMinute + second:         "2 minutes 1 second ",
+		2*secondsInAMinute + 10*second:      "2 minutes 10 seconds ",
+		59*secondsInAMinute + 59*second:     "59 minutes 59 seconds ",
+		secondsInAHour:                      "1 hour ",


iulianpascalau

We should think about how to change the cpu stats

…7225-termui-updates

bogdan-rosianu · 2020-08-12T09:38:16Z

cmd/node/metrics/machineStatistics.go

 )

-// StartMachineStatisticsPolling will start read information about current  running machini
-func StartMachineStatisticsPolling(ash core.AppStatusHandler, pollingInterval time.Duration) error {
+// StartMachineStatisticsPolling will start read information about current  running machine


remove a blank space between current and running

bogdan-rosianu · 2020-08-12T09:41:00Z

core/statistics/machine/netStatistics.go

@@ -119,3 +138,13 @@ func (ns *NetStatistics) PercentSent() uint64 {
 func (ns *NetStatistics) PercentRecv() uint64 {
 	return atomic.LoadUint64(&ns.percentRecv)
 }
+
+// TotalBytesSendInCurrentEpoch returns total bytes send in current epoch


// TotalBytesSendInCurrentEpoch returns the number of bytes sent in the current epoch *
also rename func name to Sent instead of Send

bogdan-rosianu · 2020-08-12T09:42:27Z

statusHandler/presenter/systemLoadsGetters.go

@@ -53,3 +53,13 @@ func (psh *PresenterStatusHandler) GetNetworkSentBps() uint64 {
 func (psh *PresenterStatusHandler) GetNetworkSentBpsPeak() uint64 {
 	return psh.getFromCacheAsUint64(core.MetricNetworkSentBpsPeak)
 }
+
+// GetNetworkSendBytesInEpoch will return total bytes send in current epoch
+func (psh *PresenterStatusHandler) GetNetworkSendBytesInEpoch() uint64 {


bogdan-rosianu · 2020-08-12T09:43:28Z

statusHandler/view/termuic/termuiRenders/widgetsRender.go

+	wr.epochLoad.Percent = epochLoadPercent
+	wr.epochLoad.Label = fmt.Sprintf("%d / %d rounds (~%sremaining)", currentEpochRound, currentEpochFinishRound, remainingTime)
+
+	totalBytesSendInEpoch := wr.presenter.GetNetworkSendBytesInEpoch()


bogdan-rosianu · 2020-08-12T09:43:39Z

statusHandler/view/termuic/termuiRenders/widgetsRender.go

+
+	wr.networkBytesInEpoch.Title = "Epoch - traffic:"
+	wr.networkBytesInEpoch.Percent = 0
+	wr.networkBytesInEpoch.Label = fmt.Sprintf("send: %s / received: %s", core.ConvertBytes(totalBytesSendInEpoch), core.ConvertBytes(totalBytesReceivedInEpoch))


iulianpascalau

As suggested by @LucianMincu we might make it obvious that the network stats are per host, not per process.

LucianMincu · 2020-08-16T20:33:37Z

I suggest to provide a screenshot of the changes implemented among a short documentation about each metric that should be proposed to the validator community for peer review. 🙏

miiu96 · 2020-08-24T07:39:44Z

Also was added new 2 metrics in API route /node/status:

erd_network_recv_bytes_in_epoch - provides an estimation of total bytes that was received in current epoch
erd_network_sent_bytes_in_epoch - provides an estimation of total bytes that was sent in current epoch

iulianpascalau · 2020-08-24T14:01:54Z

Also was added new 2 metrics in API route /node/status:

erd_network_recv_bytes_in_epoch - provides an estimation of total bytes that was received in current epoch

erd_network_sent_bytes_in_epoch - provides an estimation of total bytes that was sent in current epoch

maybe change Epoch - traffic: to Epoch - traffic per host: and Network - sent per host: and Network - receive per host: also, might rename the constants retrieved in the API routes?

miiu96 · 2020-08-25T06:28:06Z

Constants name was changed:

erd_network_recv_bytes_in_epoch_per_host
erd_network_sent_bytes_in_epoch_per_host

mihaib79 · 2020-08-25T07:36:46Z

I keep getting: termui websocket terminated: close 1006 (abnormal closure): unexpected EOF

Also the network traffic percents are overlapping the windows' borders. It gets even worse when shrinking the terminal window.

mihaib79 · 2020-08-25T07:39:52Z

sent per host
receive per host

should be sent/received or send/receive ... use the same verb tense, please

mihaib79 · 2020-08-25T07:43:15Z

traffic per host shows 0 / 0

miiu96 · 2020-08-27T06:58:25Z

Done.

LucianMincu

👍

miiu96 and others added 3 commits August 7, 2020 14:35

termui updates

4d4c430

small fixes

2b59734

Merge branch 'development' into EN-7225-termui-updates

8f7458e

bogdan-rosianu reviewed Aug 10, 2020

View reviewed changes

miiu96 marked this pull request as ready for review August 11, 2020 07:18

miiu96 and others added 2 commits August 11, 2020 10:18

Merge branch 'development' into EN-7225-termui-updates

38e7f6d

small fix

3792612

miiu96 changed the title ~~Termui updates [WIP]~~ Termui updates Aug 11, 2020

Merge branch 'development' into EN-7225-termui-updates

f23b65c

iulianpascalau self-requested a review August 11, 2020 14:00

iulianpascalau previously approved these changes Aug 11, 2020

View reviewed changes

miiu96 added 2 commits August 12, 2020 12:29

added network traffic in current epoch

53b15fd

Merge remote-tracking branch 'origin/EN-7225-termui-updates' into EN-…

5eab514

…7225-termui-updates

miiu96 dismissed iulianpascalau’s stale review via 5eab514 August 12, 2020 09:30

bogdan-rosianu requested changes Aug 12, 2020

View reviewed changes

miiu96 added 2 commits August 12, 2020 13:20

fix after first review

d355fd6

small fix

cc2b9fe

bogdan-rosianu previously approved these changes Aug 12, 2020

View reviewed changes

miiu96 and others added 6 commits August 13, 2020 12:24

Merge branch 'development' into EN-7225-termui-updates

c01dc8f

Merge branch 'development' into EN-7225-termui-updates

9875013

Merge branch 'development' into EN-7225-termui-updates

468199d

Merge branch 'development' into EN-7225-termui-updates

ea8dc53

Merge branch 'development' into EN-7225-termui-updates

8d619ae

Merge branch 'development' into EN-7225-termui-updates

01a9dda

iulianpascalau reviewed Aug 15, 2020

View reviewed changes

Merge branch 'development' into EN-7225-termui-updates

1ec73e9

bogdan-rosianu and others added 2 commits August 18, 2020 15:44

Merge branch 'development' into EN-7225-termui-updates

496937d

Merge branch 'development' into EN-7225-termui-updates

a14e34a

Merge branch 'development' into EN-7225-termui-updates

039ed66

small fix

9926931

miiu96 dismissed bogdan-rosianu’s stale review via 9926931 August 25, 2020 06:34

iulianpascalau previously approved these changes Aug 25, 2020

View reviewed changes

small fix

f7377d0

miiu96 dismissed iulianpascalau’s stale review via f7377d0 August 25, 2020 12:24

miiu96 and others added 3 commits August 26, 2020 09:40

Merge branch 'development' into EN-7225-termui-updates

50a97a6

Merge branch 'development' into EN-7225-termui-updates

ec8b657

Merge branch 'development' into EN-7225-termui-updates

0c18dec

miiu96 self-assigned this Aug 27, 2020

bogdan-rosianu approved these changes Aug 27, 2020

View reviewed changes

Merge branch 'development' into EN-7225-termui-updates

c012dae

mihaib79 approved these changes Aug 28, 2020

View reviewed changes

iulianpascalau approved these changes Aug 28, 2020

View reviewed changes

miiu96 added 3 commits August 28, 2020 13:45

Merge branch 'development' into EN-7225-termui-updates

4557574

Merge branch 'development' into EN-7225-termui-updates

8b1556a

Merge branch 'development' into EN-7225-termui-updates

f6e98d3

LucianMincu approved these changes Aug 28, 2020

View reviewed changes

LucianMincu merged commit 27d4298 into development Aug 28, 2020

LucianMincu deleted the EN-7225-termui-updates branch August 28, 2020 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Termui updates #2212

Termui updates #2212

miiu96 commented Aug 7, 2020 •

edited

bogdan-rosianu Aug 10, 2020

miiu96 Aug 11, 2020

iulianpascalau left a comment

bogdan-rosianu Aug 12, 2020

miiu96 Aug 12, 2020

bogdan-rosianu Aug 12, 2020

miiu96 Aug 12, 2020

bogdan-rosianu Aug 12, 2020

miiu96 Aug 12, 2020

bogdan-rosianu Aug 12, 2020

miiu96 Aug 12, 2020

bogdan-rosianu Aug 12, 2020

miiu96 Aug 12, 2020

iulianpascalau left a comment

LucianMincu commented Aug 16, 2020

miiu96 commented Aug 24, 2020 •

edited

iulianpascalau commented Aug 24, 2020

miiu96 commented Aug 25, 2020

mihaib79 commented Aug 25, 2020

mihaib79 commented Aug 25, 2020

mihaib79 commented Aug 25, 2020

miiu96 commented Aug 27, 2020

LucianMincu left a comment

Termui updates #2212

Termui updates #2212

Conversation

miiu96 commented Aug 7, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iulianpascalau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iulianpascalau left a comment

Choose a reason for hiding this comment

LucianMincu commented Aug 16, 2020

miiu96 commented Aug 24, 2020 • edited

iulianpascalau commented Aug 24, 2020

miiu96 commented Aug 25, 2020

mihaib79 commented Aug 25, 2020

mihaib79 commented Aug 25, 2020

mihaib79 commented Aug 25, 2020

miiu96 commented Aug 27, 2020

LucianMincu left a comment

Choose a reason for hiding this comment

miiu96 commented Aug 7, 2020 •

edited

miiu96 commented Aug 24, 2020 •

edited