Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchanges integration - additions #2217

Merged
merged 6 commits into from
Aug 14, 2020
Merged

Conversation

andreibancioiu
Copy link
Collaborator

@andreibancioiu andreibancioiu commented Aug 11, 2020

  • return notarized blocks (not only their hashes)
  • rename some API response fields (for full history)
  • full history bugfix (get meta block by hash was not working)

How to test:

curl http://metachain-full-history-observer:8080/block/by-nonce/42
curl http://metachain-full-history-observer:8080/block/by-nonce/42?withTxs=true

And inspect the notarized blocks in the response.

curl http://metachain-full-history-observer:8080/block/by-hash/abcd...
curl http://metachain-full-history-observer:8080/block/by-hash/abcd...?withTxs=true

And inspect the response.

@andreibancioiu andreibancioiu added the type:feature New feature or request label Aug 11, 2020
@andreibancioiu andreibancioiu self-assigned this Aug 11, 2020
@AdoAdoAdo AdoAdoAdo self-requested a review August 12, 2020 11:17
@sasurobert sasurobert self-requested a review August 12, 2020 11:19
AdoAdoAdo
AdoAdoAdo previously approved these changes Aug 12, 2020
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 5d38bba into development Aug 14, 2020
@LucianMincu LucianMincu deleted the exchanges-integration-dev branch August 14, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants