Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use block tracker alongside headers pool #2221

Merged
merged 4 commits into from
Aug 14, 2020

Conversation

SebastianMarian
Copy link
Contributor

@SebastianMarian SebastianMarian commented Aug 12, 2020

  • Fixed an edge case situation when self headers were removed from headers pool after a forced roll back action. This caused sometimes that computeSelfNotarizedHeaders from block tracker, which had used only headers pool for searching headers, to not found/return them. Furthmore, registered call handlers which should been notified about self notarized headers extracted from a received cross header were not called too, as these headers were not been found in headers pool.

Testing steps:

a) Prerequisites

b) Test steps
Start a normal testnet, with forks, restarts and txs

c) Expected results
Shards and meta nodes should recover faster after a forced roll back (action which cleans headers pool above the roll back nonce). We can grab then in logs after message: "roll back one block has been forced"
and check after how many rounds nodes have been proposed the next block (it should be around 1 or 2 rounds)

d) Actual results
Test process is in pending

…aders pool after a forced roll back action. This caused sometimes that computeSelfNotarizedHeaders from block tracker, which had used only headers pool for searching headers, to not found/return them. Furthmore, registered call handlers which should been notified about self notarized headers extracted from a received cross header were not called too, as these headers were not been found in headers pool.
@SebastianMarian SebastianMarian added type:bug Something isn't working type:feature New feature or request labels Aug 12, 2020
@SebastianMarian SebastianMarian self-assigned this Aug 12, 2020
@iulianpascalau iulianpascalau self-requested a review August 12, 2020 18:37
@sasurobert sasurobert self-requested a review August 12, 2020 19:08
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 25d4187 into development Aug 14, 2020
@LucianMincu LucianMincu deleted the use-block-tracker-alongside-headers-pool branch August 14, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants