Index relayed transactions #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
requested changes
Aug 14, 2020
| @@ -118,8 +130,20 @@ func (tdp *txDatabaseProcessor) prepareTransactionsForDatabase( | |||
| return append(convertMapTxsToSlice(transactions), rewardsTxs...) | |||
| } | |||
|
|
|||
| func (tdp *txDatabaseProcessor) addScResultInfoInTx(scr *smartContractResult.SmartContractResult, tx *Transaction) *Transaction { | |||
| dbScResult := tdp.commonProcessor.convertScResultInDatabaseScr(scr) | |||
| func findAllChildScrResults(hash string, scrs map[string]*smartContractResult.SmartContractResult) map[string]*smartContractResult.SmartContractResult { | |||
There was a problem hiding this comment.
add unit tests for intrashard and cross shard relayed smart contracts. verify how those are indexed.
There was a problem hiding this comment.
done. added a unit tests and did a lot of manual test to check if transaction are indexed correctly
There was a problem hiding this comment.
maybe rename it as this function also removes elements from the map received as parameter
sasurobert
approved these changes
Aug 17, 2020
| @@ -187,59 +187,27 @@ func (cm *commonProcessor) buildRewardTransaction( | |||
| } | |||
| } | |||
|
|
|||
| func (cm *commonProcessor) convertScResultInDatabaseScr(sc *smartContractResult.SmartContractResult) ScResult { | |||
| decodedData := decodeScResultData(sc.Data) | |||
| func (cm *commonProcessor) convertScResultInDatabaseScr(scHash string, sc *smartContractResult.SmartContractResult) ScResult { | |||
| @@ -98,6 +106,10 @@ func (tdp *txDatabaseProcessor) prepareTransactionsForDatabase( | |||
| } | |||
| } | |||
|
|
|||
| if strings.Contains(string(transactions[hash].Data), "relayedTx") { | |||
There was a problem hiding this comment.
use core->constants.go->RelayedTransaction
| tx1 := &transaction.Transaction{ | ||
| GasLimit: 100, | ||
| GasPrice: 100, | ||
| Data: []byte("relayedTx@blablabllablalba"), |
There was a problem hiding this comment.
can use a prettier mock data
bogdan-rosianu
approved these changes
Aug 18, 2020
LucianMincu
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index in elastic search also smart contract results that are generated by relayed transactions.