En 7316 add call value sc query #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
requested changes
Aug 13, 2020
facade/interface.go
Outdated
| @@ -69,6 +69,7 @@ type NodeHandler interface { | |||
| // ApiResolver defines a structure capable of resolving REST API requests | |||
| type ApiResolver interface { | |||
| ExecuteSCQuery(query *process.SCQuery) (*vmcommon.VMOutput, error) | |||
| ExecuteQueryWithCallerAndValue(query *process.SCQuery, callerAddr []byte, callValue *big.Int) (*vmcommon.VMOutput, error) | |||
There was a problem hiding this comment.
change the SCQuery data - add callerAddr and callValue inside - no need to change the interface and add these values
| @@ -42,26 +44,57 @@ func NewSCQueryService( | |||
|
|
|||
| // ExecuteQuery returns the VMOutput resulted upon running the function on the smart contract | |||
| func (service *SCQueryService) ExecuteQuery(query *process.SCQuery) (*vmcommon.VMOutput, error) { | |||
| if query.ScAddress == nil { | |||
| return nil, process.ErrNilScAddress | |||
| err := checkQueryFields(query) | |||
There was a problem hiding this comment.
No need for second function. Use ExecuteQuery and fill the value and callerAddress as they were before if those are empty.
sasurobert
approved these changes
Aug 14, 2020
raduchis
approved these changes
Aug 14, 2020
LucianMincu
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two optional parameters to API endpoint
vm-values(callerandvalue) and extended the functionality in order to be able to include the thecallerAddrandcallValueinside the SC query service.Testing steps:
/vm-values/intfor example in which you will specify the caller address and the call value. Can be astaketransaction.