Fix how tps benchmark is calculated #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdoAdoAdo
reviewed
Aug 25, 2020
core/statistics/tpsBenchmark.go
Outdated
|
|
||
| func getNumTxsFromMiniblocksWithoutPeerTxs(miniblocks []block.MiniBlockHeader) uint64 { | ||
| totalTxs := uint64(0) | ||
| for idx := 0; idx < len(miniblocks); idx++ { |
There was a problem hiding this comment.
can you use range instead?
core/statistics/tpsBenchmark.go
Outdated
| totalTxs := getNumTxsFromMiniblocksWithoutPeerTxs(metaBlock.MiniBlockHeaders) | ||
|
|
||
| // get number of transactions from shard blocks that are included in metablock | ||
| for idx := 0; idx < len(metaBlock.ShardInfo); idx++ { |
There was a problem hiding this comment.
can you use range instead?
sasurobert
previously approved these changes
Aug 25, 2020
AdoAdoAdo
previously approved these changes
Aug 25, 2020
sasurobert
previously approved these changes
Aug 26, 2020
AdoAdoAdo
previously approved these changes
Aug 26, 2020
sasurobert
approved these changes
Aug 27, 2020
AdoAdoAdo
approved these changes
Aug 27, 2020
LucianMincu
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify how tps benchmark is calculated.
Now all the peer transactions and smart contract results are ignored on computation for all the metrics.