Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the situation when empty receipts would have been saved #2238

Merged
merged 1 commit into from
Aug 25, 2020
Merged

fixed the situation when empty receipts would have been saved #2238

merged 1 commit into from
Aug 25, 2020

Conversation

bogdan-rosianu
Copy link
Contributor

Previously, the function which computed the receipts hash would have returned a hash even if no receipts was present. Added an extra check

@bogdan-rosianu bogdan-rosianu added the type:bug Something isn't working label Aug 25, 2020
@bogdan-rosianu bogdan-rosianu self-assigned this Aug 25, 2020
LucianMincu
LucianMincu approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed

@LucianMincu LucianMincu merged commit 3ff48ce into development Aug 25, 2020
@LucianMincu LucianMincu deleted the receipts-fix-empty-slice-put branch August 25, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

Assignees

@bogdan-rosianu bogdan-rosianu

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bogdan-rosianu @sasurobert @LucianMincu @SebastianMarian