Es search order field #2241
Es search order field #2241
Conversation
…ork/elrond-go into es-search-order-field
| @@ -248,6 +251,33 @@ func (tdp *txDatabaseProcessor) groupNormalTxsAndRewards( | |||
| return transactions, rewardsTxs | |||
| } | |||
|
|
|||
| func (tdp *txDatabaseProcessor) setTransactionSearchOrder(transactions map[string]*Transaction, shardId uint32) map[string]*Transaction { | |||
| currentOrder := 0 | |||
| shardIdentifier := tdp.createShardIdentifier(shardId) | |||
There was a problem hiding this comment.
ShardID is the parameter passed to the function. I used "identifier" to: 1. avoid name collision and 2. to avoid confusion between an actual shard id in Elrond context and this custom identifier
| currentOrder := 0 | ||
| shardIdentifier := tdp.createShardIdentifier(shardId) | ||
|
|
||
| for _, tx := range transactions { |
There was a problem hiding this comment.
The iteration is done over a map. This will not ensure the same order each time. Does it matter?
There was a problem hiding this comment.
You are right. But we don't care. The only thing we are interested in here is to have a tie breaker for the front end where the shard id is the same and the (round) timestamp is the same
| shardIdentifier := tdp.createShardIdentifier(shardId) | ||
|
|
||
| for _, tx := range transactions { | ||
| stringOrder := fmt.Sprintf("%d%d", shardIdentifier, currentOrder) |
There was a problem hiding this comment.
The 10th tx of metachain will have the order 110 which will be higher than the 9th tx of the shard 2 which will have the order 49. Does it matter for the logic that you needed from this method?
There was a problem hiding this comment.
That's right but we don't care about that. We already can have a tie breaker and sort by shard id. We only need to have a rank between items in the same shard and the same indexed bulk
|
|
||
| func (esd *elasticSearchDatabase) computeBlockSearchOrder(header data.HeaderHandler) uint32 { | ||
| shardIdentifier := esd.txDatabaseProcessor.createShardIdentifier(header.GetShardID()) | ||
| stringOrder := fmt.Sprintf("%d%d", shardIdentifier, header.GetNonce()) |
There was a problem hiding this comment.
The 10th nonce of metachain will have the order 110 which will be higher than the 9th nonce of the shard 2 which will have the order 49. Does it matter for the logic that you needed from this method?
There was a problem hiding this comment.
That's right but we don't care about that. We already can have a tie breaker and sort by shard id. We only need to have a rank between items in the same shard and the same indexed bulk
Added new field to be indexed in elastic. This helps the front end using the "search_after" parameter to scroll deeper than 10k elements.