Add marshalized receipts in storer #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ins all the marshalized receipts in clear and not only their hashes
sasurobert
reviewed
Aug 26, 2020
bogdan-rosianu
requested changes
Aug 26, 2020
process/coordinator/process.go
Outdated
| return nil, nil | ||
| } | ||
|
|
||
| receiptsBatch := &batch.Batch{Data: receiptsHashes} | ||
| marshalizedReceiptsHashes, err := tc.marshalizer.Marshal(receiptsBatch) | ||
| marshalizedReceiptsBatch, err := tc.marshalizer.Marshal(receiptsBatch) |
There was a problem hiding this comment.
could return directly
bogdan-rosianu
approved these changes
Aug 26, 2020
sasurobert
approved these changes
Aug 26, 2020
LucianMincu
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps:
a) Prerequisites
b) Test steps
Start a normal testnet
c) Expected results
We should have another storage/folder/db created in: .../Epoch_X/Shard_Y/Receipts which holds cumulative receipt hash as a key and all the marshalized receipts list marshalized as a value, for each committed block
d) Actual results
Test process is in pending