Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bughunt WARN messages on bech32 pubkey converter #2246

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Bughunt WARN messages on bech32 pubkey converter #2246

merged 3 commits into from
Aug 27, 2020

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Aug 27, 2020 •
edited

  • added prints in pruning storer
  • fixed a bech32 conversion WARN in indexer
  • added stack dump in pubkey converter to easily debug wrong usage of a pub key converter

@iulianpascalau iulianpascalau marked this pull request as ready for review August 27, 2020 14:49
@iulianpascalau iulianpascalau changed the title Bughunt open persisters Bughunt WARN messages on bech32 pubkey converter Aug 27, 2020
SebastianMarian
SebastianMarian approved these changes Aug 27, 2020
View reviewed changes
storage/pruning/pruningStorer.go
log.Debug("initPersistersInEpoch",
"StartingEpoch", args.StartingEpoch,
"NumOfEpochsToKeep", args.NumOfEpochsToKeep,
"oldestEpochKeep", oldestEpochKeep,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oldestEpochKept ?

LucianMincu
LucianMincu approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 02cda75 into development Aug 27, 2020
@LucianMincu LucianMincu deleted the bughunt-open-persisters branch August 27, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucianMincu LucianMincu LucianMincu approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

@miiu96 miiu96 miiu96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iulianpascalau @LucianMincu @SebastianMarian @miiu96