-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
En 7369 stop node after offline sync #2248
En 7369 stop node after offline sync #2248
Conversation
…e import process can safely shutdown the node when completed
crtEpoch := hdrRes.manualEpochStartNotifier.CurrentEpoch() | ||
strEpochNotFound := fmt.Sprintf("%d", crtEpoch) | ||
if crtEpoch > 1 { | ||
strEpochNotFound = strEpochNotFound + fmt.Sprintf(" or %d", crtEpoch-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strEpochNotFound += fmt.Sprintf(" or %d", crtEpoch-1)
or maybe if we want to print them in ascending order:
strEpochNotFound = fmt.Sprintf("%d or %d", crtEpoch-1, crtEpoch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not crtEpoch and crtEpoch+1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, will change the print
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System tests passed.
Manual testing procedures:
import-db
, place the directory near theconfig
directory.db
directory or without a DB.DestinationShardAsObserver
option in prefs.toml to match the containing DB directories and desired shard../node -use-log-view -log-level *:INFO -log-save -import-db ./import-db
.Note: please check that the node has at least 3 peer connections, otherwise the sync and consensus mechanism are paused.