Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stop offline syncer #2255

Merged
merged 3 commits into from
Aug 29, 2020
Merged

Fix stop offline syncer #2255

merged 3 commits into from
Aug 29, 2020

Conversation

iulianpascalau
Copy link
Contributor

  • fixed the stopping process when importing data with the offline syncer

Testing procesures:

  • as in PR En 7369 stop node after offline sync #2248, the import process should run as expected until a missing data error happens. This time can be any data (tx, miniblock, nonce-hash, receipt, etc.), not just the hash-header info.

LucianMincu
LucianMincu approved these changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 5899c01 into development Aug 29, 2020
@LucianMincu LucianMincu deleted the fix-stop-offline-syncer branch August 29, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iulianpascalau @sasurobert @LucianMincu @SebastianMarian