Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix epoch set in manual epoch notifier #2258

Merged
merged 5 commits into from
Aug 31, 2020
Merged

Fix epoch set in manual epoch notifier #2258

merged 5 commits into from
Aug 31, 2020

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Aug 30, 2020 •
edited

  • fixed the initial epoch after the instantiation of the manualEpochStartNotifier object
  • automatically alter checkpoint modulus value when importing DB

Testing procedures:

  • start the import process, let it sync for about 5 epochs
  • close the node that does the import
  • restart the process
    Expected results:
  • the node should resume its import process, should not close prematurely stating:
terminating at internal stop signal      reason = importComplete description = import ended because data from epochs 0 or 1 does not exist

@iulianpascalau iulianpascalau self-assigned this Aug 30, 2020
@iulianpascalau iulianpascalau added the type:bug Something isn't working label Aug 30, 2020
sasurobert
sasurobert previously approved these changes Aug 31, 2020
View reviewed changes
AdoAdoAdo
AdoAdoAdo previously approved these changes Aug 31, 2020
View reviewed changes
SebastianMarian
SebastianMarian reviewed Aug 31, 2020
View reviewed changes
cmd/node/main.go
config.GeneralSettings.StartInEpochEnabled = false
config.StateTriesConfig.CheckpointRoundsModulus = importCheckpointRoundsModulus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not: config.StateTriesConfig.CheckpointRoundsModulus = uint(config.EpochStartConfig.RoundsPerEpoch)
and you can remove importCheckpointRoundsModulus constant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@iulianpascalau
- removed import constant
5c8f764 
- removed some warnings and weak warnings in structs.go
- added a TODO for a later renaming
LucianMincu
LucianMincu approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit b457f98 into development Aug 31, 2020
@LucianMincu LucianMincu deleted the fix-epoch-set-in-manualEpochNotifier branch August 31, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@AdoAdoAdo AdoAdoAdo AdoAdoAdo approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

Assignees

@iulianpascalau iulianpascalau

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iulianpascalau @sasurobert @LucianMincu @AdoAdoAdo @SebastianMarian