EN-7433: storer to elastic - fix miniblock not found #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,16 +156,18 @@ func (dp *dataProcessor) indexData(data *storer2ElasticData.HeaderData) error { | |||
| notarizedHeaders := dp.computeNotarizedHeaders(data.Header) | |||
| newBody := &block.Body{MiniBlocks: make([]*block.MiniBlock, 0)} | |||
| for _, mb := range data.Body.MiniBlocks { | |||
| if mb.Type == block.ReceiptBlock { // don't index receipt miniblocks | |||
| if mb.Type == block.ReceiptBlock || | |||
There was a problem hiding this comment.
maybe extract into a variable?
| @@ -81,7 +81,9 @@ func (dr *databaseReader) GetDatabaseInfo() ([]*DatabaseInfo, error) { | |||
| epochStr := re.FindString(dirname) | |||
| epoch, errParseInt := strconv.ParseInt(epochStr, 10, 64) | |||
| if errParseInt != nil { | |||
| log.Warn("cannot parse epoch number from directory name", "directory name", dirname) | |||
| if dirname != "Static" { | |||
There was a problem hiding this comment.
done. also in other places
…lock-prev-epoch' into EN-7433-storer2elastic-fix-miniblock-prev-epoch
iulianpascalau
previously approved these changes
Aug 31, 2020
sasurobert
previously approved these changes
Aug 31, 2020
bogdan-rosianu
dismissed stale reviews from sasurobert and iulianpascalau
via
cd1a8df
sasurobert
approved these changes
Sep 4, 2020
iulianpascalau
approved these changes
Sep 4, 2020
LucianMincu
deleted the
EN-7433-storer2elastic-fix-miniblock-prev-epoch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing procedure is the same as for #2249