Add node watcher to testnet scripts #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| iterateOverValidators stopSingleValidator | ||
| } | ||
|
|
||
| iterateOverValidators() { |
There was a problem hiding this comment.
almost duplicate code with iterateOverObservers
There was a problem hiding this comment.
Due to Bash specifics, these two duplicated functions are cleaner than a single deduplicated iterator (at least at my level of knowledge). A future rewrite in Python will allow for cleaner code.
| echo "$source_command ; $watcher_command" | ||
| } | ||
|
|
||
| assembleCommand_startValidatorNode() { |
There was a problem hiding this comment.
this doesn't actually start the node but assemble the command line for a node
There was a problem hiding this comment.
Yes, the function is called assembleCommand_startValidatorNode(). Can rename to something else if unclear.
sasurobert
requested changes
Aug 31, 2020
iulianpascalau
approved these changes
Sep 1, 2020
sasurobert
approved these changes
Sep 1, 2020
AdoAdoAdo
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is now a variable called
NODE_WATCHER, set by default to 1. This variable enables the so-called node watcher, a daemon which restarts the node if it dies.Enabling the node watcher will also make the node a daemon. This means that it cannot be stopped with CTRL+C from tmux anymore.
A better solution must be implemented. The current node watcher was designed with a different use case in mind, and is somewhat incompatible with the testnet scripts.