DNS test scenarios #2266
Merged
DNS test scenarios #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/elrond-go into dns-test-scenarios
| @@ -60,7 +58,7 @@ func (s *saveUserName) ProcessBuiltinFunction( | |||
| if !ok { | |||
| return nil, process.ErrCallerIsNotTheDNSAddress | |||
| } | |||
| if len(vmInput.Arguments) != 1 || len(vmInput.Arguments[0]) != userNameHashLength { | |||
| if len(vmInput.Arguments) != 1 { | |||
There was a problem hiding this comment.
A maximum length would be good here.
There was a problem hiding this comment.
No need. We control the DNS SCs which are only allowed to call this
bogdan-rosianu
approved these changes
Sep 3, 2020
camilbancioiu
approved these changes
Sep 4, 2020
LucianMincu
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a set of DNS test scenarios - all works as expected