En 7380 early end of epoch #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Sep 3, 2020
•
iulianpascalau
commented
- added early end of epoch implementation that can be used in the hardfork process
- changed how bech32PubkeyConverter does the stack dump
- added interceptor & resolver debugger in hardfork exporter
…dfork process - changed how bech32PubkeyConverter does the stack dump
…end the hardfork message - added early-end-of-epoch integration test
# Conflicts: # integrationTests/multiShard/smartContract/scCallingSC_test.go
| @@ -9,6 +9,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/ElrondNetwork/elrond-go/crypto/peerSignatureHandler" | |||
| "github.com/ElrondNetwork/elrond-go/epochStart/notifier" | |||
|
|
|||
There was a problem hiding this comment.
Remove empty line.
scripts/testnet/hardfork.sh
Outdated
| fi | ||
|
|
||
| if [ -z "$2" ]; then | ||
| echo "epoch argument was not provided. Usage: './hardfork.sh [epoch: number] [forced: true|false]' as in './hardfork.sh 1 false'" |
There was a problem hiding this comment.
forced argument, not epoch
bogdan-rosianu
requested changes
Sep 8, 2020
api/hardfork/routes_test.go
Outdated
| @@ -99,7 +99,7 @@ func TestTrigger_TriggerCanNotExecuteShouldErr(t *testing.T) { | |||
|
|
|||
| expectedErr := errors.New("expected error") | |||
| ws := startNodeServer(&mock.HardforkFacade{ | |||
| TriggerCalled: func(epoch uint32) error { | |||
| TriggerCalled: func(epoch uint32, forced bool) error { | |||
api/hardfork/routes_test.go
Outdated
| @@ -144,7 +144,7 @@ func TestTrigger_ManualShouldWork(t *testing.T) { | |||
| } | |||
| buffHr, _ := json.Marshal(hr) | |||
| ws := startNodeServer(&mock.HardforkFacade{ | |||
| TriggerCalled: func(epoch uint32) error { | |||
| TriggerCalled: func(epoch uint32, forced bool) error { | |||
sasurobert
requested changes
Sep 8, 2020
api/hardfork/routes.go
Outdated
| @@ -18,14 +18,15 @@ const ( | |||
|
|
|||
| // FacadeHandler interface defines methods that can be used by the gin webserver | |||
| type FacadeHandler interface { | |||
| Trigger(epoch uint32) error | |||
| Trigger(epoch uint32, forced bool) error | |||
| ) | ||
|
|
||
| // TriggerHandler defines the functionalities for an start of epoch trigger | ||
| type TriggerHandler interface { | ||
| Close() error | ||
| ForceEpochStart(round uint64) error | ||
| ForceEpochStart() |
There was a problem hiding this comment.
Don't you need current round?
There was a problem hiding this comment.
nope, it is taken automatically as the next possible round. Took into consideration the MinRoundsBetweenEpochs config value
update/trigger/trigger.go
Outdated
| @@ -202,7 +205,16 @@ func (t *trigger) computeAndSetTrigger(epoch uint32, originalPayload []byte) (bo | |||
| t.recordedTriggerMessage = originalPayload | |||
| } | |||
|
|
|||
| if epoch > t.epochProvider.MetaEpoch() { | |||
| if forced { | |||
- added more debug prints for hardfork
bogdan-rosianu
previously approved these changes
Sep 8, 2020
BeniaminDrasovean
previously approved these changes
Sep 9, 2020
iulianpascalau
dismissed stale reviews from BeniaminDrasovean and bogdan-rosianu
via
899377c
bogdan-rosianu
previously approved these changes
Sep 9, 2020
# Conflicts: # integrationTests/testProcessorNode.go
- removed some weak warnings
# Conflicts: # integrationTests/testInitializer.go
sasurobert
approved these changes
Oct 7, 2020
bogdan-rosianu
approved these changes
Oct 7, 2020
BeniaminDrasovean
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.