Bug fix panic tps benchmark #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Sep 8, 2020
core/statistics/tpsBenchmark.go
Outdated
| @@ -179,8 +179,13 @@ func (s *TpsBenchmark) NrOfShards() uint32 { | |||
| // ShardStatistics returns the current statistical state for a given shard | |||
| func (s *TpsBenchmark) ShardStatistics() map[uint32]ShardStatistic { | |||
| s.mut.RLock() | |||
| defer s.mut.RUnlock() | |||
| return s.shardStatistics | |||
| copyMapShardStatistics := make(map[uint32]ShardStatistic) | |||
There was a problem hiding this comment.
Seems fine, I see that updateStatistics is protected by the same lock.
There was a problem hiding this comment.
rename to shardStatisticsMapCopy
bogdan-rosianu
requested changes
Sep 8, 2020
core/statistics/tpsBenchmark.go
Outdated
| @@ -179,8 +179,13 @@ func (s *TpsBenchmark) NrOfShards() uint32 { | |||
| // ShardStatistics returns the current statistical state for a given shard | |||
| func (s *TpsBenchmark) ShardStatistics() map[uint32]ShardStatistic { | |||
| s.mut.RLock() | |||
| defer s.mut.RUnlock() | |||
| return s.shardStatistics | |||
| copyMapShardStatistics := make(map[uint32]ShardStatistic) | |||
There was a problem hiding this comment.
rename to shardStatisticsMapCopy
| func TestTpsBenchmark_ShardStatisticConcurrentAccess(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| tpsBenchmark, _ := statistics.NewTPSBenchmark(12, 4) |
There was a problem hiding this comment.
use recover() as you should check that no panic has encountered during the test
bogdan-rosianu
approved these changes
Sep 8, 2020
andreibancioiu
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix concurrent access on map that store shard statistics information for TPS Benchmark.
When method ShardStatistics() is called will return a copy of map that contains shard statistics.