Improve block tracker computation time #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SebastianMarian
commented
Sep 8, 2020
SebastianMarian
commented
- Improved block tracker computation time, when received headers are behind final or if registered handlers lists which should be notified on new headers received are empty
…behind final or if registered handlers lists which should be notified on new headers received are empty
sasurobert
previously approved these changes
Sep 8, 2020
bogdan-rosianu
previously approved these changes
Sep 8, 2020
| @@ -6,8 +6,9 @@ import ( | |||
|
|
|||
| // BlockNotifierHandlerMock - | |||
| type BlockNotifierHandlerMock struct { | |||
There was a problem hiding this comment.
could be renamed to stub
process/track/blockProcessor_test.go
Outdated
| @@ -174,10 +186,15 @@ func TestProcessReceivedHeader_ShouldWorkWhenHeaderIsFromSelfShard(t *testing.T) | |||
| return nil, nil, nil, nil | |||
| }, | |||
| } | |||
| blockProcessorArguments.SelfNotarizer = &mock.BlockNotarizerHandlerMock{ | |||
| GetLastNotarizedHeaderCalled: func(shardID uint32) (data.HeaderHandler, []byte, error) { | |||
| return &block2.Header{}, nil, nil | |||
There was a problem hiding this comment.
rename package from block2 to something else
…n-time' into Improve-block-tracker-computation-time
SebastianMarian
dismissed stale reviews from bogdan-rosianu and sasurobert
via
e02c4ea
bogdan-rosianu
previously approved these changes
Sep 8, 2020
sasurobert
previously approved these changes
Sep 8, 2020
…xtracted from received cross headers
SebastianMarian
dismissed stale reviews from sasurobert and bogdan-rosianu
via
e993d3f
bogdan-rosianu
approved these changes
Sep 9, 2020
sasurobert
approved these changes
Sep 9, 2020
LucianMincu
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.