wrapped vm output api response #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // GetFirstReturnData is a helper function that returns the first ReturnData of VMOutput, interpreted as specified. | ||
| func (vmOutput *VMOutputApi) GetFirstReturnData(asType vmcommon.ReturnDataKind) (interface{}, error) { |
There was a problem hiding this comment.
added unit tests for all cases (as big int, as big int string, as hex and as string)
facade/nodeFacade.go
Outdated
| func (nf *nodeFacade) convertVmOutputToApiResponse(input *vmcommon.VMOutput) *vm.VMOutputApi { | ||
| outputAccounts := make(map[string]*vm.OutputAccountApi) | ||
| for key, acc := range input.OutputAccounts { | ||
| outPutAddress, err := nf.node.EncodeAddressPubkey(acc.Address) |
SebastianMarian
previously approved these changes
Sep 14, 2020
iulianpascalau
approved these changes
Sep 14, 2020
SebastianMarian
approved these changes
Sep 14, 2020
LucianMincu
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a wrapped structure which will be returned when calling a
vm-valuesendpoint. Now it will display addresses in bech32 format when needed and added custom json tags (with lowercase)Testing procedure:
vm-values/queryfor example and the output should follow json format and not having unreadable characters