Unit test elastic indexer #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/indexer/dataDispatcher.go # core/indexer/elasticProcessor_test.go
miiu96
changed the title
| @@ -237,7 +237,7 @@ func (ei *elasticProcessor) RemoveMiniblocks(header data.HeaderHandler, body *bl | |||
|
|
|||
| isDstMe := selfShardID == miniblock.ReceiverShardID | |||
| isCrossShard := miniblock.ReceiverShardID != miniblock.SenderShardID | |||
| if !(isDstMe && isCrossShard) { | |||
| if isDstMe && isCrossShard { | |||
There was a problem hiding this comment.
So the condition is completely reversed. The bulk remove is not done anymore for cross miniblocks wit dest me.
There was a problem hiding this comment.
Yes. Now is right because if a miniblock is indexed on source shard and if a rollback appears cross shard miniblocks should not be removed because I have to keep information that was indexed on source shard. When miniblock will be executed again on destination shard information will be rewritten.
# Conflicts: # core/indexer/dataDispatcher.go # core/indexer/dataDispatcher_test.go # core/indexer/errors.go # core/indexer/workItems/workItemRemoveBlock.go
SebastianMarian
approved these changes
Sep 17, 2020
sasurobert
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test for package core/indexer