standard tx status responses #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianMarian
approved these changes
Sep 15, 2020
andreibancioiu
approved these changes
Sep 22, 2020
| // TxStatusPending = received and maybe executed on source shard, but not on destination shard | ||
| TxStatusPending TxStatus = "pending" | ||
| // TxStatusSuccessful = received and executed | ||
| TxStatusSuccessful TxStatus = "successful" |
There was a problem hiding this comment.
Breaking change for the exchanges consuming the API. But we will deal with in on the Proxy side somwhow 🥳
Perhaps we can introduce a v2 prefix in the URL on the Proxy (and re-map to old names in v1 URLs).
There was a problem hiding this comment.
added a jira ticket with ID EN-7718
| failReason := "" | ||
| retCode, err := ts.txProcessor.ProcessTransaction(tx) | ||
| if err != nil { | ||
| failReason = err.Error() | ||
| txStatus = transaction.TxStatusNotExecuted | ||
| txStatus = transaction.TxStatusUnsuccessful |
There was a problem hiding this comment.
Actually, here it is really non-executed. But Unsuccessful should be all right for most purposes, correct?
There was a problem hiding this comment.
yes, it can remain like this. this type of status would have been returned also on the normal transaction sending
LucianMincu
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed transactions' statuses for indexer and API transaction status fetcher. Now they use the same messages from the same place.
Changes:
Elastic Search responses:
API transaction status responses:
Meanings:
Invalid/invalid: the transaction is invalid and won't be processed. will be changed to invalid
partially-executed: executed only in sender shard. in order to abstract sharding terminology, it will be changed to pending
received: in the pool on sender shard, but not executed yet. will be changed to pending
Not Executed/not-executed: processing of the transaction failed. will be changed to unsuccessful
Success/executed: fully-executed transaction. will be changed to successful for consistency