Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of the same consensus message type from the same pk #2301

Merged
merged 5 commits into from
Sep 21, 2020

Conversation

SebastianMarian
Copy link
Contributor

@SebastianMarian SebastianMarian commented Sep 17, 2020

  • Implemented a mechanism which limits the number of the same consensus message type which could be received/accepted in one round from the same public key

…us message type which could be received in one round from the same public key
@SebastianMarian SebastianMarian added the type:feature New feature or request label Sep 17, 2020
@SebastianMarian SebastianMarian self-assigned this Sep 17, 2020
@sasurobert sasurobert self-requested a review September 17, 2020 14:51
sasurobert
sasurobert previously approved these changes Sep 17, 2020
consensus/spos/bls/subroundStartRound.go Show resolved Hide resolved
consensus/spos/consensusMessageValidator.go Outdated Show resolved Hide resolved
consensus/spos/worker.go Outdated Show resolved Hide resolved

mapMsgType, ok := wrk.mapPkConsensusMessages[string(pk)]
key := fmt.Sprintf("%s_%d", string(pk), round)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit ee8f0c2 into development Sep 21, 2020
@LucianMincu LucianMincu deleted the Limit_number_of_consensus_messages branch September 21, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants