RegisterNonce for waiting and view function #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return vmcommon.UserError | ||
| } | ||
|
|
||
| stakedData, err := r.getOrCreateRegisteredData(element.BLSPublicKey) |
There was a problem hiding this comment.
getOrCreate? Shouldn't have been just get?
There was a problem hiding this comment.
it is ok. it shouldn't happen to create here - only bad programming
iulianpascalau
previously approved these changes
Sep 21, 2020
iulianpascalau
previously approved these changes
Sep 23, 2020
| func (stp *stakingToPeer) getStorageFromAccount(userAcc state.UserAccountHandler, key []byte) []byte { | ||
| value, err := userAcc.DataTrieTracker().RetrieveValue(key) | ||
| if err != nil { | ||
| return nil |
There was a problem hiding this comment.
log.Trace the error?
There was a problem hiding this comment.
it is log traced in retrievevalue.
| nextKey := make([]byte, len(waitingElementKey)) | ||
| copy(nextKey, prevElement.NextKey) | ||
| for len(nextKey) != 0 { | ||
| for len(nextKey) != 0 && index <= waitingListHead.Length { |
There was a problem hiding this comment.
index < waitingListHead.Length ?
There was a problem hiding this comment.
Index starts from 1
| index := uint32(1) | ||
| nextKey := make([]byte, len(waitingListHead.FirstKey)) | ||
| copy(nextKey, waitingListHead.FirstKey) | ||
| for len(nextKey) != 0 && index <= waitingListHead.Length { |
There was a problem hiding this comment.
index < waitingListHead.Length ?
There was a problem hiding this comment.
Index starts from 1
SebastianMarian
approved these changes
Sep 23, 2020
iulianpascalau
approved these changes
Sep 24, 2020
| @@ -1255,7 +1255,7 @@ func (r *stakingSC) getBLSKeyStatus(args *vmcommon.ContractCallInput) vmcommon.R | |||
| return vmcommon.Ok | |||
| } | |||
| if stakedData.Waiting { | |||
| r.eei.Finish([]byte("waiting")) | |||
| r.eei.Finish([]byte("queued")) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegisterNonce for waiting and view function.
This code is backward compatible if stake was not enabled - after that it is not. Should be merged before enabling staking.