Sync tracker pool with headers pool #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from tracker are requested (in this situation a delete will be done in headers pool, just to be sure that the notifiy event will be called for the requested/received header, even if in some edge case situations the requested header exists only in headers pool but not in tracker pool)
SebastianMarian
added
type:bug
sasurobert
previously approved these changes
Sep 21, 2020
| @@ -255,7 +255,9 @@ func (bp *baseProcessor) requestHeadersIfMissing( | |||
| missingNonces = append(missingNonces, nonces...) | |||
| } | |||
|
|
|||
| headersPool := bp.dataPool.Headers() | |||
There was a problem hiding this comment.
some tests for the added code would be nice.
There was a problem hiding this comment.
would be added until the system tests are done
sasurobert
approved these changes
Sep 21, 2020
iulianpascalau
approved these changes
Sep 21, 2020
LucianMincu
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This situation could appear only in some rare events of restarting the node after more than 1000 rounds from its last commit