set-to-jail-from-inactive #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch after jailing is enabled.
| } | ||
|
|
||
| if peerAccount.GetUnStakedEpoch() == core.DefaultUnstakedEpoch && peerAccount.GetList() == string(core.InactiveList) { | ||
| peerAccount.SetListAndIndex(validator.ShardId, string(core.JailedList), validator.Index) |
There was a problem hiding this comment.
The same set here and in line 669. Why not extract both conditions in shouldBeJailed variable and reduce the code
There was a problem hiding this comment.
Not exactly the same. Would leave as it is
There was a problem hiding this comment.
It is only 1 line of code.
raduchis
approved these changes
Sep 25, 2020
| return | ||
| } | ||
|
|
||
| if peerAccount.GetUnStakedEpoch() == core.DefaultUnstakedEpoch && peerAccount.GetList() == string(core.InactiveList) { |
There was a problem hiding this comment.
no need for the validator.List == string (core.JailedList) ? Could it be not jailed in validator.List and still want to set it to jailed based on the new condition?
There was a problem hiding this comment.
This is for the scenario when in old code it was set to inactive, and should have been set to jailed
SebastianMarian
approved these changes
Sep 25, 2020
LucianMincu
approved these changes
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set to jailed when account is inactive and with infinite unstaked epoch after jailing is enabled.