Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved subround EndRound and fixed some mocks/linter warns #2323

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Improved subround EndRound and fixed some mocks/linter warns #2323

merged 3 commits into from
Sep 25, 2020

Conversation

SebastianMarian
Copy link
Contributor

@SebastianMarian SebastianMarian commented Sep 25, 2020 •
edited

  • Improved subround EndRound for final info
  • Fixed some mocks
  • Fixed some linter warns

@SebastianMarian SebastianMarian added the type:feature New feature or request label Sep 25, 2020
@SebastianMarian SebastianMarian self-assigned this Sep 25, 2020
@sasurobert sasurobert self-requested a review September 25, 2020 09:43
@sasurobert sasurobert marked this pull request as ready for review September 25, 2020 09:54
@SebastianMarian SebastianMarian changed the title Improve subround EndRound Improved subround EndRound and fixed some mocks/linter warns Sep 25, 2020
LucianMincu
LucianMincu approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit b83223c into development Sep 25, 2020
@LucianMincu LucianMincu deleted the Additional-checks-for-final-info branch September 25, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@AdoAdoAdo AdoAdoAdo AdoAdoAdo approved these changes

Assignees

@SebastianMarian SebastianMarian

Labels
type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SebastianMarian @sasurobert @LucianMincu @AdoAdoAdo