Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receipt-hash-unjail #2325

Merged
merged 2 commits into from
Sep 28, 2020
Merged

receipt-hash-unjail #2325

merged 2 commits into from
Sep 28, 2020

Conversation

sasurobert
Copy link
Contributor

receipt hash missmatch because config was not added into scr as in mainnet

iulianpascalau
iulianpascalau reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing in progress

vm/systemSmartContracts/staking.go
@@ -311,6 +311,14 @@ func (r *stakingSC) changeRewardAddress(args *vmcommon.ContractCallInput) vmcomm
return vmcommon.Ok
}

func (r *stakingSC) removeFromJailedNodes() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

iulianpascalau
iulianpascalau previously approved these changes Sep 28, 2020
View reviewed changes
LucianMincu
LucianMincu approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 30f1012 into development Sep 28, 2020
@LucianMincu LucianMincu deleted the receipt-hash-unJail branch September 28, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucianMincu LucianMincu LucianMincu approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sasurobert @LucianMincu @iulianpascalau @SebastianMarian