Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts DB fixes + prints #2326

Merged
merged 10 commits into from
Sep 28, 2020
Merged

Accounts DB fixes + prints #2326

merged 10 commits into from
Sep 28, 2020

Conversation

iulianpascalau
Copy link
Contributor

  • removed some direct nil comparison in accounts DB
  • added prints for IsValidator function

Base automatically changed from receipt-hash-unJail to development September 28, 2020 14:49
@sasurobert sasurobert self-requested a review September 28, 2020 14:51
sasurobert
sasurobert previously approved these changes Sep 28, 2020
View reviewed changes
LucianMincu
LucianMincu previously approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sasurobert
sasurobert requested changes Sep 28, 2020
View reviewed changes
integrationTests/vm/systemVM/stakingSC_test.go Outdated
@@ -200,6 +219,25 @@ func TestStakingUnstakingAndUnboundingOnMultiShardEnvironmentWithValidatorStatis

checkAccountsAfterStaking(t, nodes)

//manually setting every un-staked node status to inactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take out in a function. Duplicated code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

LucianMincu
LucianMincu approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LucianMincu LucianMincu merged commit 8ea88f1 into development Sep 28, 2020
@LucianMincu LucianMincu deleted the receipt-hash-unJail-state-and-prints branch September 28, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iulianpascalau @sasurobert @LucianMincu @SebastianMarian